Issue 330263002: Eliminate overflow check for non-overflowing smi << operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 330263002: Eliminate overflow check for non-overflowing smi << operations. (Closed)

Created:
6 years, 6 months ago by Florian Schneider

Modified:
6 years, 6 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Compute ranges for >> smi shifts and eliminate overflow check for smi << operations. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37541

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -26 lines)			Patch
M	runtime/vm/il_printer.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3 4 5	3 chunks	+14 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2 3 4 5 6	4 chunks	+28 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2 3 4 5	4 chunks	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 2 3 4 5	4 chunks	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4 5	4 chunks	+4 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2 3 4 5	4 chunks	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_test.cc	View	1 2 3 4 5 6	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3 4 5	4 chunks	+4 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

Cutch

lgtm but I'd like to hold off landing until I land my mint change.

6 years, 6 months ago (2014-06-19 15:47:27 UTC) #3

Florian Schneider

On 2014/06/19 15:47:27, Cutch wrote: > lgtm but I'd like to hold off landing until ...

6 years, 6 months ago (2014-06-20 09:47:00 UTC) #4

Florian Schneider

6 years, 6 months ago (2014-06-20 12:07:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #7 manually as r37541 (presubmit successful).