Support paths outside of "bin" for pub run.

Support paths outside of "bin" for pub run.

BUG=https://code.google.com/p/dart/issues/detail?id=18536
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37322

[nweiz, 2014-06-12 23:27:08]

https://codereview.chromium.org/330183003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/run.dart (right):

https://codereview.chromium.org/330183003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/run.dart:62: if
(script.contains(path.separator)) {
"/" should work on windows as well. I suggest "path.split(script).length != 1".

https://codereview.chromium.org/330183003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/run.dart:64: rootDir =
path.split(script)[0];
Nit: I prefer ".first" to "[0]" if it's the only element being accessed.

Why is this serving everything beneath the first path component? Shouldn't it
serve the directory directly containing [script] to avoid extra
loading/transformation work?

[Bob Nystrom, 2014-06-13 00:42:29]

I fixed up the progress stuff to play nice with pub run which uses a log mode
where messages aren't shown. PTAL.

https://codereview.chromium.org/330183003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/run.dart (right):

https://codereview.chromium.org/330183003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/run.dart:62: if
(script.contains(path.separator)) {
On 2014/06/12 23:27:08, nweiz wrote:
> "/" should work on windows as well. I suggest "path.split(script).length !=
1".

Done.

https://codereview.chromium.org/330183003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/run.dart:64: rootDir =
path.split(script)[0];
On 2014/06/12 23:27:08, nweiz wrote:
> Nit: I prefer ".first" to "[0]" if it's the only element being accessed.

Done.

> Why is this serving everything beneath the first path component? Shouldn't it
> serve the directory directly containing [script] to avoid extra
> loading/transformation work?

Good question. I forgot we can serve subdirectories.

Do we care about other assets in the directory tree? What if I do pub run
tool/sub/foo.dart and it imports "../bar.dart"?

[nweiz, 2014-06-13 00:43:48]

lgtm

https://codereview.chromium.org/330183003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/run.dart (right):

https://codereview.chromium.org/330183003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/run.dart:64: rootDir =
path.split(script)[0];
On 2014/06/13 00:42:29, Bob Nystrom wrote:
> On 2014/06/12 23:27:08, nweiz wrote:
> > Nit: I prefer ".first" to "[0]" if it's the only element being accessed.
> 
> Done.
> 
> > Why is this serving everything beneath the first path component? Shouldn't
it
> > serve the directory directly containing [script] to avoid extra
> > loading/transformation work?
> 
> Good question. I forgot we can serve subdirectories.
> 
> Do we care about other assets in the directory tree? What if I do pub run
> tool/sub/foo.dart and it imports "../bar.dart"?

That's probably worth supporting, especially for tests. Can you add a test case
for it?

[Bob Nystrom, 2014-06-13 17:30:15]

Committed patchset #4 manually as r37322 (presubmit successful).

[Bob Nystrom, 2014-06-13 17:30:21]

Thanks!

https://codereview.chromium.org/330183003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command/run.dart (right):

https://codereview.chromium.org/330183003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command/run.dart:64: rootDir =
path.split(script)[0];
On 2014/06/13 00:43:48, nweiz wrote:
> On 2014/06/13 00:42:29, Bob Nystrom wrote:
> > On 2014/06/12 23:27:08, nweiz wrote:
> > > Nit: I prefer ".first" to "[0]" if it's the only element being accessed.
> > 
> > Done.
> > 
> > > Why is this serving everything beneath the first path component? Shouldn't
> it
> > > serve the directory directly containing [script] to avoid extra
> > > loading/transformation work?
> > 
> > Good question. I forgot we can serve subdirectories.
> > 
> > Do we care about other assets in the directory tree? What if I do pub run
> > tool/sub/foo.dart and it imports "../bar.dart"?
> 
> That's probably worth supporting, especially for tests. Can you add a test
case
> for it?

Done.