Issue 33003005: Make sure we do not have stale entries inside build-dir/packages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 33003005: Make sure we do not have stale entries inside build-dir/packages (Closed)

Created:
7 years, 2 months ago by kustermann

Modified:
7 years, 2 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make sure we do not have stale entries inside build-dir/packages R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=29062

Patch Set 2 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	dart/tools/make_links.py	View	1	2 chunks	+12 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM, with suggestion to simplify https://codereview.chromium.org/33003005/diff/1/dart/tools/make_links.py File dart/tools/make_links.py (right): https://codereview.chromium.org/33003005/diff/1/dart/tools/make_links.py#newcode64 dart/tools/make_links.py:64: if os.path.exists(target): why not ...

7 years, 2 months ago (2013-10-23 07:45:44 UTC) #2

kustermann

https://codereview.chromium.org/33003005/diff/1/dart/tools/make_links.py File dart/tools/make_links.py (right): https://codereview.chromium.org/33003005/diff/1/dart/tools/make_links.py#newcode64 dart/tools/make_links.py:64: if os.path.exists(target): On 2013/10/23 07:45:44, ricow1 wrote: > why ...

7 years, 2 months ago (2013-10-23 07:57:39 UTC) #3

kustermann

7 years, 2 months ago (2013-10-23 07:57:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r29062 (presubmit successful).

Expand Messages | Collapse Messages

Issue 33003005: Make sure we do not have stale entries inside build-dir/packages (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages