Updated webdriver setup script to use new location for downloads.

Updated webdriver setup script to use new location for downloads.

R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29200

[Emily Fortuna, 2013-10-21 17:19:37]

https://codereview.chromium.org/33003002/diff/30001/tools/testing/webdriver_t...
File tools/testing/webdriver_test_setup.py (right):

https://codereview.chromium.org/33003002/diff/30001/tools/testing/webdriver_t...
tools/testing/webdriver_test_setup.py:84: class ChromeDriverInstaller(object):
This is a bad idea as the Dart browser driver does not work on all platform
browser combinations. Removing the setup functionality here is too premature.

[Andrei Mouravski, 2013-10-21 19:07:08]

PTAL.

[Emily Fortuna, 2013-10-21 20:29:46]

https://codereview.chromium.org/33003002/diff/70001/tools/testing/webdriver_t...
File tools/testing/webdriver_test_setup.py (right):

https://codereview.chromium.org/33003002/diff/70001/tools/testing/webdriver_t...
tools/testing/webdriver_test_setup.py:84: class ChromeDriverInstaller(object):
can this be refactored? can in it extend GoogleCodeInstaller? Seems like there's
repeated code for get_os_str and others.

https://codereview.chromium.org/33003002/diff/70001/tools/testing/webdriver_t...
tools/testing/webdriver_test_setup.py:94: self.google_storage_downloads_page =
'http://chromedriver.storage.googleapis.com'
80 char

[Andrei Mouravski, 2013-10-22 00:11:51]

PTAL.

https://codereview.chromium.org/33003002/diff/70001/tools/testing/webdriver_t...
File tools/testing/webdriver_test_setup.py (right):

https://codereview.chromium.org/33003002/diff/70001/tools/testing/webdriver_t...
tools/testing/webdriver_test_setup.py:84: class ChromeDriverInstaller(object):
On 2013/10/21 20:29:46, Emily Fortuna wrote:
> can this be refactored? can in it extend GoogleCodeInstaller? Seems like
there's
> repeated code for get_os_str and others.

Aye, I'll do that.

[Emily Fortuna, 2013-10-22 17:12:53]

https://codereview.chromium.org/33003002/diff/120001/tools/testing/webdriver_...
File tools/testing/webdriver_test_setup.py (right):

https://codereview.chromium.org/33003002/diff/120001/tools/testing/webdriver_...
tools/testing/webdriver_test_setup.py:84: """Install a project from the web,
pulling latest version."""
maybe call this something like GoogleBasedInstaller since these projects were
all originally hosted on Google code. That distinguishes them from Firefox and
Opera, etc because those have their own variants of get_os_str.

https://codereview.chromium.org/33003002/diff/120001/tools/testing/webdriver_...
tools/testing/webdriver_test_setup.py:101: raise NotImplementedError
Use duck typing -- you don't need to put this "unimplemented" method here. it's
not Java.

https://codereview.chromium.org/33003002/diff/120001/tools/testing/webdriver_...
tools/testing/webdriver_test_setup.py:110: """
nit: can put this '"" on the previous line

https://codereview.chromium.org/33003002/diff/120001/tools/testing/webdriver_...
tools/testing/webdriver_test_setup.py:170: l = f.read()
better variable names please

[Andrei Mouravski, 2013-10-24 18:19:33]

PTAL.

https://codereview.chromium.org/33003002/diff/120001/tools/testing/webdriver_...
File tools/testing/webdriver_test_setup.py (right):

https://codereview.chromium.org/33003002/diff/120001/tools/testing/webdriver_...
tools/testing/webdriver_test_setup.py:84: """Install a project from the web,
pulling latest version."""
On 2013/10/22 17:12:53, Emily Fortuna wrote:
> maybe call this something like GoogleBasedInstaller since these projects were
> all originally hosted on Google code. That distinguishes them from Firefox and
> Opera, etc because those have their own variants of get_os_str.

Done.

https://codereview.chromium.org/33003002/diff/120001/tools/testing/webdriver_...
tools/testing/webdriver_test_setup.py:101: raise NotImplementedError
On 2013/10/22 17:12:53, Emily Fortuna wrote:
> Use duck typing -- you don't need to put this "unimplemented" method here.
it's
> not Java.

Done.

https://codereview.chromium.org/33003002/diff/120001/tools/testing/webdriver_...
tools/testing/webdriver_test_setup.py:110: """
On 2013/10/22 17:12:53, Emily Fortuna wrote:
> nit: can put this '"" on the previous line

Done.

https://codereview.chromium.org/33003002/diff/120001/tools/testing/webdriver_...
tools/testing/webdriver_test_setup.py:170: l = f.read()
On 2013/10/22 17:12:53, Emily Fortuna wrote:
> better variable names please

Done.

[Emily Fortuna, 2013-10-24 19:48:45]

https://codereview.chromium.org/33003002/diff/170001/tools/testing/webdriver_...
File tools/testing/webdriver_test_setup.py (right):

https://codereview.chromium.org/33003002/diff/170001/tools/testing/webdriver_...
tools/testing/webdriver_test_setup.py:84: """Install a project from the web,
pulling latest version."""
update comments?

https://codereview.chromium.org/33003002/diff/170001/tools/testing/webdriver_...
tools/testing/webdriver_test_setup.py:89: project_name - Name of the project,
such as "selenium" or "chromedriver."
google code "name of the project"

https://codereview.chromium.org/33003002/diff/170001/tools/testing/webdriver_...
tools/testing/webdriver_test_setup.py:422: GoogleCodeInstaller('selenium',
os.path.dirname(os.path.abspath(__file__)),
ummm do you even run this code? GoogleCodeInstaller doesn't exist anymore
because you renamed it.

[Andrei Mouravski, 2013-10-24 19:51:41]

PTAL.

https://codereview.chromium.org/33003002/diff/170001/tools/testing/webdriver_...
File tools/testing/webdriver_test_setup.py (right):

https://codereview.chromium.org/33003002/diff/170001/tools/testing/webdriver_...
tools/testing/webdriver_test_setup.py:84: """Install a project from the web,
pulling latest version."""
On 2013/10/24 19:48:46, Emily Fortuna wrote:
> update comments?

Done.

https://codereview.chromium.org/33003002/diff/170001/tools/testing/webdriver_...
tools/testing/webdriver_test_setup.py:89: project_name - Name of the project,
such as "selenium" or "chromedriver."
On 2013/10/24 19:48:46, Emily Fortuna wrote:
> google code "name of the project"

Done.

https://codereview.chromium.org/33003002/diff/170001/tools/testing/webdriver_...
tools/testing/webdriver_test_setup.py:422: GoogleCodeInstaller('selenium',
os.path.dirname(os.path.abspath(__file__)),
On 2013/10/24 19:48:46, Emily Fortuna wrote:
> ummm do you even run this code? GoogleCodeInstaller doesn't exist anymore
> because you renamed it.

It does exist. Line 169.

[Emily Fortuna, 2013-10-24 19:53:43]

lgtm

[Andrei Mouravski, 2013-10-24 20:01:53]

Committed patchset #6 manually as r29200 (presubmit successful).