Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 329993005: Mark standalone/io/skip_dart2js_compilations_test as failing on Win. (Closed)

Created:
6 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark standalone/io/skip_dart2js_compilations_test as failing on Win. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=37490

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tests/standalone/standalone.status View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
6 years, 6 months ago (2014-06-19 12:30:51 UTC) #1
Søren Gjesse
lgtm, with comment https://codereview.chromium.org/329993005/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/329993005/diff/1/tests/standalone/standalone.status#newcode146 tests/standalone/standalone.status:146: [ $system = windows ] = ...
6 years, 6 months ago (2014-06-19 12:33:12 UTC) #2
Lasse Reichstein Nielsen
6 years, 6 months ago (2014-06-19 12:40:17 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r37490 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698