Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 329983002: Implement references to "this" in the new IR. (Closed)

Created:
6 years, 6 months ago by sigurdm
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implement references to "this" in the new IR. R=asgerf@google.com, kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=37588

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -6 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart View 1 5 chunks +17 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/tree_tracer.dart View 1 2 chunks +5 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart View 1 4 chunks +21 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart View 1 2 chunks +7 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ir/ir_tracer.dart View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sigurdm
6 years, 6 months ago (2014-06-12 09:14:50 UTC) #1
asgerf
lgtm
6 years, 6 months ago (2014-06-12 09:25:55 UTC) #2
Kevin Millikin (Google)
lgtm
6 years, 6 months ago (2014-06-20 09:21:06 UTC) #3
sigurdm
6 years, 6 months ago (2014-06-23 09:35:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r37588 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698