Remove platform.js from polymer.html, hint in the linter that it should be used

Remove platform.js from polymer.html, hint in the linter that it should be used
directly in the entrypoint.

R=jmesserly@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37332

[Siggi Cherem (dart-lang), 2014-06-13 20:08:37]

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/lib/src/buil...
File pkg/polymer/lib/src/build/linter.dart (right):

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/lib/src/buil...
pkg/polymer/lib/src/build/linter.dart:207:
_logger.error(NO_IMPORT_WITHIN_ELEMENT, span: node.sourceSpan);
this is unrelated to the rest of the changes, but should at least warn about
https://code.google.com/p/dart/issues/detail?id=18340

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/test/bind_md...
File pkg/polymer/test/bind_mdv_test.html (left):

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/test/bind_md...
pkg/polymer/test/bind_mdv_test.html:13: <script
src="/packages/web_components/platform.concat.js"></script>
was this on purpose?

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/test/build/c...
File pkg/polymer/test/build/common.dart (right):

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/test/build/c...
pkg/polymer/test/build/common.dart:79: expect(messagesSeen,
lessThanOrEqualTo(messages.length),
this makes failure messages more accurate

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/test/build/c...
pkg/polymer/test/build/common.dart:122: expect(messagesSeen, messages.length,
ditto

https://codereview.chromium.org/329923002/diff/70001/samples/samples.status
File samples/samples.status (left):

https://codereview.chromium.org/329923002/diff/70001/samples/samples.status#o...
samples/samples.status:9: polymer_intl: Fail # Issue 18059
this was bogus (this is tracked in pkgbuild)

[Jennifer Messerly, 2014-06-13 21:07:48]

a few comments but overall LGTM

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/lib/polymer....
File pkg/polymer/lib/polymer.html (right):

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/lib/polymer....
pkg/polymer/lib/polymer.html:9: https://github.com/Polymer/platform/ and
https://github.com/Polymer/polymer/.
we could remove platform?

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/lib/src/buil...
File pkg/polymer/lib/src/build/linter.dart (right):

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/lib/src/buil...
pkg/polymer/lib/src/build/linter.dart:440: const String NO_IMPORT_WITHIN_ELEMENT
= 'HTML imports are not supported '
maybe improve the wording so it's clearly an issue with our Polymer.dart deploy
tool?

The web components folks get grumpy if we appear to be saying something in the
standard is not supported. :)

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/test/bind_md...
File pkg/polymer/test/bind_mdv_test.html (left):

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/test/bind_md...
pkg/polymer/test/bind_mdv_test.html:13: <script
src="/packages/web_components/platform.concat.js"></script>
On 2014/06/13 20:08:37, Siggi Cherem (dart-lang) wrote:
> was this on purpose?

hmmm. maybe. Might be nice to have one test of .concat?

https://codereview.chromium.org/329923002/diff/70001/samples/third_party/todo...
File samples/third_party/todomvc/test/listorder_test.html (right):

https://codereview.chromium.org/329923002/diff/70001/samples/third_party/todo...
samples/third_party/todomvc/test/listorder_test.html:13: <script
src="packages/web_components/platform.js"></script>
spacing seems off?

[Siggi Cherem (dart-lang), 2014-06-13 22:12:20]

Committed patchset #1 manually as r37332 (presubmit successful).

[Siggi Cherem (dart-lang), 2014-06-13 22:15:28]

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/lib/polymer....
File pkg/polymer/lib/polymer.html (right):

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/lib/polymer....
pkg/polymer/lib/polymer.html:9: https://github.com/Polymer/platform/ and
https://github.com/Polymer/polymer/.
On 2014/06/13 21:07:47, John Messerly wrote:
> we could remove platform?

oops, done.

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/lib/src/buil...
File pkg/polymer/lib/src/build/linter.dart (right):

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/lib/src/buil...
pkg/polymer/lib/src/build/linter.dart:440: const String NO_IMPORT_WITHIN_ELEMENT
= 'HTML imports are not supported '
On 2014/06/13 21:07:47, John Messerly wrote:
> maybe improve the wording so it's clearly an issue with our Polymer.dart
deploy
> tool?
> 
> The web components folks get grumpy if we appear to be saying something in the
> standard is not supported. :)

Done.

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/test/bind_md...
File pkg/polymer/test/bind_mdv_test.html (left):

https://codereview.chromium.org/329923002/diff/70001/pkg/polymer/test/bind_md...
pkg/polymer/test/bind_mdv_test.html:13: <script
src="/packages/web_components/platform.concat.js"></script>
On 2014/06/13 21:07:47, John Messerly wrote:
> On 2014/06/13 20:08:37, Siggi Cherem (dart-lang) wrote:
> > was this on purpose?
> 
> hmmm. maybe. Might be nice to have one test of .concat?

good point. reverted this back.

https://codereview.chromium.org/329923002/diff/70001/samples/third_party/todo...
File samples/third_party/todomvc/test/listorder_test.html (right):

https://codereview.chromium.org/329923002/diff/70001/samples/third_party/todo...
samples/third_party/todomvc/test/listorder_test.html:13: <script
src="packages/web_components/platform.js"></script>
On 2014/06/13 21:07:47, John Messerly wrote:
> spacing seems off?

Done.

[Siggi Cherem (dart-lang), 2014-06-13 22:51:18]

oops - I intended to include Keerti in this review from the beginning, sorry I
forgot last minute :(