Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 329723002: Identify the name of the prototype extended by out-of-app custom elements (Closed)

Created:
6 years, 6 months ago by sra1
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Visibility:
Public.

Description

Identify the name of the prototype extended by out-of-app custom elements BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=37247

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/web_components/lib/dart_support.js View 1 1 chunk +27 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
sra1
6 years, 6 months ago (2014-06-11 04:14:31 UTC) #1
sra1
6 years, 6 months ago (2014-06-11 17:25:06 UTC) #2
Siggi Cherem (dart-lang)
https://codereview.chromium.org/329723002/diff/60001/pkg/web_components/lib/dart_support.js File pkg/web_components/lib/dart_support.js (right): https://codereview.chromium.org/329723002/diff/60001/pkg/web_components/lib/dart_support.js#newcode124 pkg/web_components/lib/dart_support.js:124: window.dartNativeDispatchHooksTransformer.push(function(hooks) { should we also check for !!ShadowDOMPOlyfill? Seems ...
6 years, 6 months ago (2014-06-11 19:34:57 UTC) #3
sra1
https://codereview.chromium.org/329723002/diff/60001/pkg/web_components/lib/dart_support.js File pkg/web_components/lib/dart_support.js (right): https://codereview.chromium.org/329723002/diff/60001/pkg/web_components/lib/dart_support.js#newcode124 pkg/web_components/lib/dart_support.js:124: window.dartNativeDispatchHooksTransformer.push(function(hooks) { On 2014/06/11 19:34:57, Siggi Cherem (dart-lang) wrote: ...
6 years, 6 months ago (2014-06-11 19:43:24 UTC) #4
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/329723002/diff/80001/pkg/web_components/lib/dart_support.js File pkg/web_components/lib/dart_support.js (right): https://codereview.chromium.org/329723002/diff/80001/pkg/web_components/lib/dart_support.js#newcode123 pkg/web_components/lib/dart_support.js:123: // take care of above. nit: take => ...
6 years, 6 months ago (2014-06-11 19:56:03 UTC) #5
sra1
6 years, 6 months ago (2014-06-11 22:26:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r37247 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698