Issue 329403007: Warn about accessing private properties, but don't choke on it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 329403007: Warn about accessing private properties, but don't choke on it. (Closed)

Created:
6 years, 6 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 6 months ago

Reviewers:
justinfagnani, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Warn about accessing private properties, but don't choke on it. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=37634

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -8 lines)			Patch
	M	pkg/polymer/lib/src/build/script_compactor.dart	View		5 chunks	+20 lines, -8 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://codereview.chromium.org/329403007/diff/1/pkg/polymer/lib/src/build/script_compactor.dart File pkg/polymer/lib/src/build/script_compactor.dart (right): https://codereview.chromium.org/329403007/diff/1/pkg/polymer/lib/src/build/script_compactor.dart#newcode609 pkg/polymer/lib/src/build/script_compactor.dart:609: generator.addGetter(name); these APIs will cause a later failure if ...

6 years, 6 months ago (2014-06-24 00:58:13 UTC) #1

Jennifer Messerly

lgtm, definitely an improvement :) though I worry longer term about this warning and false ...

6 years, 6 months ago (2014-06-24 01:16:31 UTC) #2

Siggi Cherem (dart-lang)

On 2014/06/24 01:16:31, John Messerly wrote: > lgtm, definitely an improvement :) > > though ...

6 years, 6 months ago (2014-06-24 01:20:54 UTC) #3

Siggi Cherem (dart-lang)

6 years, 6 months ago (2014-06-24 01:22:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r37634 (presubmit successful).

Expand Messages | Collapse Messages