Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 329303006: Add "--dry-run" to pub upgrade. (Closed)

Created:
6 years, 6 months ago by Bob Nystrom
Modified:
6 years, 6 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add "--dry-run" to pub upgrade. BUG=https://code.google.com/p/dart/issues/detail?id=15243 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=37319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -22 lines) Patch
M sdk/lib/_internal/pub/lib/src/command/upgrade.dart View 1 chunk +20 lines, -8 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/entrypoint.dart View 2 chunks +11 lines, -8 lines 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 2 chunks +5 lines, -6 lines 0 comments Download
A sdk/lib/_internal/pub/test/upgrade/dry_run_does_not_apply_changes_test.dart View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
6 years, 6 months ago (2014-06-12 22:39:27 UTC) #1
nweiz
lgtm I'd add this for "pub get" as well. It's less likely to make changes, ...
6 years, 6 months ago (2014-06-12 23:07:11 UTC) #2
Bob Nystrom
On 2014/06/12 23:07:11, nweiz wrote: > lgtm > > I'd add this for "pub get" ...
6 years, 6 months ago (2014-06-13 17:11:58 UTC) #3
Bob Nystrom
6 years, 6 months ago (2014-06-13 17:12:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r37319 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698