Issue 329163003: Grow new gen (1M -> 4M -> 16M on 32-bit) when there is little garbage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 329163003: Grow new gen (1M -> 4M -> 16M on 32-bit) when there is little garbage. (Closed)

Created:
6 years, 6 months ago by koda

Modified:
6 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Grow new gen when enough of it survives. 1M default initial size is enough to run "hello world" without triggering scavenge. Default sizes are doubled on 64-bit (like old gen). Also clean up and clarify "new gen capacity". In particular, rename confusing flag "new_gen_heap_size". R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37429

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -25 lines)			Patch
M	runtime/vm/dart.cc	View	1 2 3	2 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/heap.h	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/heap.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/scavenger.h	View	1 2 4	6 chunks	+12 lines, -4 lines	0 comments	Download
M	runtime/vm/scavenger.cc	View	1 2 3 4	7 chunks	+32 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

koda

Note that this CL doesn't shrink new gen. (And as an implementation matter, shrinkage would ...

6 years, 6 months ago (2014-06-12 17:52:34 UTC) #2

koda

On 2014/06/12 17:52:34, koda wrote: > Note that this CL doesn't shrink new gen. (And ...

6 years, 6 months ago (2014-06-16 21:22:06 UTC) #3

koda

6 years, 6 months ago (2014-06-17 22:25:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r37429 (presubmit successful).

Expand Messages | Collapse Messages