Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 32903004: simple fix: loosen type annotations for ShadowRoot (Closed)

Created:
7 years, 2 months ago by Jennifer Messerly
Modified:
7 years, 2 months ago
Reviewers:
Siggi Cherem (dart-lang), sjmiles
CC:
reviews_dartlang.org
Visibility:
Public.

Description

simple fix: loosen type annotations for ShadowRoot R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=28957

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M pkg/polymer/lib/src/instance.dart View 5 chunks +18 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jennifer Messerly
7 years, 2 months ago (2013-10-21 20:48:43 UTC) #1
Jennifer Messerly
This let's you call shadowRootReady with your non-ShadowRoot DOM, for example "this".
7 years, 2 months ago (2013-10-21 20:49:47 UTC) #2
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/32903004/diff/30001/pkg/polymer/lib/src/instance.dart File pkg/polymer/lib/src/instance.dart (right): https://codereview.chromium.org/32903004/diff/30001/pkg/polymer/lib/src/instance.dart#newcode240 pkg/polymer/lib/src/instance.dart:240: void shadowRootReady(Node root, Element template) { just wondering ...
7 years, 2 months ago (2013-10-21 20:51:58 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/32903004/diff/30001/pkg/polymer/lib/src/instance.dart File pkg/polymer/lib/src/instance.dart (right): https://codereview.chromium.org/32903004/diff/30001/pkg/polymer/lib/src/instance.dart#newcode240 pkg/polymer/lib/src/instance.dart:240: void shadowRootReady(Node root, Element template) { On 2013/10/21 20:51:58, ...
7 years, 2 months ago (2013-10-21 20:56:00 UTC) #4
Jennifer Messerly
7 years, 2 months ago (2013-10-21 21:51:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r28957 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698