Begins removing intptr_t from raw object fields.

Begins removing intptr_t from raw object fields.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37285

[siva, 2014-06-11 00:38:19]

Quick comment about missing changes in raw_object_snapshot.cc

https://codereview.chromium.org/328893002/diff/40001/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://codereview.chromium.org/328893002/diff/40001/runtime/vm/raw_object.h#...
runtime/vm/raw_object.h:513: int32_t next_field_offset_in_words_;  // Offset of
the next instance field.
you would have to change raw_object_snapshot.cc
to reflect this.

e.g:

RawClass::WriteTo does:
    intptr_t class_id = ptr()->id_;
    writer->WriteIntptrValue(class_id);
This would be Write<int32_t>(....);

Class::ReadFrom does:
    intptr_t class_id = reader->ReadIntptrValue();
This would be reader->Read<int32_t>(...);

[zra, 2014-06-11 16:24:02]

https://codereview.chromium.org/328893002/diff/40001/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://codereview.chromium.org/328893002/diff/40001/runtime/vm/raw_object.h#...
runtime/vm/raw_object.h:513: int32_t next_field_offset_in_words_;  // Offset of
the next instance field.
On 2014/06/11 00:38:19, siva wrote:
> you would have to change raw_object_snapshot.cc
> to reflect this.
> 
> e.g:
> 
> RawClass::WriteTo does:
>     intptr_t class_id = ptr()->id_;
>     writer->WriteIntptrValue(class_id);
> This would be Write<int32_t>(....);
> 
> Class::ReadFrom does:
>     intptr_t class_id = reader->ReadIntptrValue();
> This would be reader->Read<int32_t>(...);

Yes, I was confused about how we were staging things, but I've included these
changes in this CL, now.

[zra, 2014-06-11 21:01:35]

PTAL

[siva, 2014-06-12 16:39:25]

lgtm

https://codereview.chromium.org/328893002/diff/60001/runtime/vm/raw_object_sn...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/328893002/diff/60001/runtime/vm/raw_object_sn...
runtime/vm/raw_object_snapshot.cc:42: intptr_t class_id =
reader->ReadIntptrValue();
This was written out as an int32_t field below so should be
Read<int32_t>()

[zra, 2014-06-12 17:34:02]

Thanks!

https://codereview.chromium.org/328893002/diff/60001/runtime/vm/raw_object_sn...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/328893002/diff/60001/runtime/vm/raw_object_sn...
runtime/vm/raw_object_snapshot.cc:42: intptr_t class_id =
reader->ReadIntptrValue();
On 2014/06/12 16:39:25, siva wrote:
> This was written out as an int32_t field below so should be
> Read<int32_t>() 

Done.

[zra, 2014-06-12 19:57:03]

Committed patchset #6 manually as r37285 (presubmit successful).