Issue 328743003: Update use lists after eliminating redundant phis.

Issue 328743003: Update use lists after eliminating redundant phis. (Closed)

Created:
6 years, 6 months ago by Florian Schneider

Modified:
6 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google), Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Update use lists after eliminating redundant phis. BUG=dartbug.com/19320 R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=37225

Patch Set 2 : addressed comments #

Total comments: 3

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -7 lines)			Patch
	M	runtime/vm/compiler.cc	View	1	2 chunks	+2 lines, -0 lines	3 comments	Download
	M	runtime/vm/flow_graph_optimizer.cc	View	1	3 chunks	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/328743003/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/328743003/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode7237 runtime/vm/flow_graph_optimizer.cc:7237: for (intptr_t j = phi->InputCount() - 1; j ...

6 years, 6 months ago (2014-06-10 17:22:29 UTC) #2

Florian Schneider

https://codereview.chromium.org/328743003/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/328743003/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode7237 runtime/vm/flow_graph_optimizer.cc:7237: for (intptr_t j = phi->InputCount() - 1; j >= ...

6 years, 6 months ago (2014-06-11 10:23:33 UTC) #3

Florian Schneider

Committed patchset #2 manually as r37225 (presubmit successful).

6 years, 6 months ago (2014-06-11 10:23:53 UTC) #4

Ivan Posva

DBC -ip https://codereview.chromium.org/328743003/diff/20001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/328743003/diff/20001/runtime/vm/compiler.cc#newcode482 runtime/vm/compiler.cc:482: DEBUG_ASSERT(flow_graph->VerifyUseLists()); What exactly is a DEBUG_ASSERT and ...

6 years, 6 months ago (2014-06-11 15:20:50 UTC) #5

Ivan Posva

On 2014/06/11 15:20:50, Ivan Posva wrote: > DBC -ip > > https://codereview.chromium.org/328743003/diff/20001/runtime/vm/compiler.cc > File runtime/vm/compiler.cc ...

6 years, 6 months ago (2014-06-11 15:28:38 UTC) #6

Florian Schneider

https://codereview.chromium.org/328743003/diff/20001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/328743003/diff/20001/runtime/vm/compiler.cc#newcode482 runtime/vm/compiler.cc:482: DEBUG_ASSERT(flow_graph->VerifyUseLists()); On 2014/06/11 15:20:50, Ivan Posva wrote: > What ...

6 years, 6 months ago (2014-06-11 15:30:32 UTC) #7

Ivan Posva

6 years, 6 months ago (2014-06-11 16:25:24 UTC) #8

Message was sent while issue was closed.

https://codereview.chromium.org/328743003/diff/20001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/328743003/diff/20001/runtime/vm/compiler.cc#n...
runtime/vm/compiler.cc:482: DEBUG_ASSERT(flow_graph->VerifyUseLists());
On 2014/06/11 15:30:31, Florian Schneider wrote:
> On 2014/06/11 15:20:50, Ivan Posva wrote:
> > What exactly is a DEBUG_ASSERT and why is it being used in this file?
> 
> 
> // DEBUG_ASSERT allows identifiers in condition to be undeclared in release
> // mode.

See followup CL, which removes the unnecessary use of DEBUG_ASSERT here.

Expand Messages | Collapse Messages