Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 327563003: Use "git log" instead of "git svn info" for revision number information, since (Closed)

Created:
6 years, 6 months ago by Emily Fortuna
Modified:
6 years, 6 months ago
Reviewers:
ricow1, blois
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Use "git log" instead of "git svn info" for revision number information, since "git svn info" hangs indefinitely on pure git checkouts. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=37374

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M tools/utils.py View 1 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Emily Fortuna
https://codereview.chromium.org/327563003/diff/1/tools/utils.py File tools/utils.py (right): https://codereview.chromium.org/327563003/diff/1/tools/utils.py#newcode373 tools/utils.py:373: stderr = subprocess.STDOUT, shell=IsWindows(), cwd = DART_DIR) Yeah, the ...
6 years, 6 months ago (2014-06-09 17:45:42 UTC) #1
ricow1
https://codereview.chromium.org/327563003/diff/1/tools/utils.py File tools/utils.py (right): https://codereview.chromium.org/327563003/diff/1/tools/utils.py#newcode371 tools/utils.py:371: # number of commits backwards (100) to get past ...
6 years, 6 months ago (2014-06-10 10:44:10 UTC) #2
Emily Fortuna
https://codereview.chromium.org/327563003/diff/1/tools/utils.py File tools/utils.py (right): https://codereview.chromium.org/327563003/diff/1/tools/utils.py#newcode371 tools/utils.py:371: # number of commits backwards (100) to get past ...
6 years, 6 months ago (2014-06-10 16:08:48 UTC) #3
Emily Fortuna
ping?
6 years, 6 months ago (2014-06-12 23:08:54 UTC) #4
blois
lgtm, would be great to get this fixed up. https://codereview.chromium.org/327563003/diff/1/tools/utils.py File tools/utils.py (right): https://codereview.chromium.org/327563003/diff/1/tools/utils.py#newcode376 tools/utils.py:376: ...
6 years, 6 months ago (2014-06-16 19:20:12 UTC) #5
Emily Fortuna
6 years, 6 months ago (2014-06-16 20:13:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r37374 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698