Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 327123002: At shutdown, remove isolate from list before tearing it down. (Closed)

Created:
6 years, 6 months ago by koda
Modified:
6 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

At shutdown, remove isolate from list before tearing it down. This avoid exposing the decaying, possibly illegal, state of the isolate to isolate visitors. BUG=dart:19219 R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37211

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M runtime/vm/isolate.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
6 years, 6 months ago (2014-06-10 23:02:19 UTC) #1
Cutch
lgtm and thanks for tracking this down!
6 years, 6 months ago (2014-06-10 23:04:42 UTC) #2
koda
6 years, 6 months ago (2014-06-10 23:12:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37211 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698