Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 32683002: Add empty dart:platform library. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Søren Gjesse, Bill Hesse, Lasse Reichstein Nielsen, kasperl, bakster
Visibility:
Public.

Description

Add empty dart:platform library. dart:platform will be a library that contains information about the runtime platform. While it's not written in stones, this is examples of properties that may be queried: - OS - Browser - Browser version - Dart Version - numberOfProcessors - pathSeparator - Native or JS VM BUG= R=ahe@google.com, asiva@google.com, floitsch@google.com, iposva@google.com, kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=29154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -9 lines) Patch
A + runtime/lib/platform_patch.dart View 1 chunk +1 line, -0 lines 0 comments Download
A + runtime/lib/platform_sources.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/bootstrap.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/object_store.h View 4 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/vm.gypi View 6 chunks +86 lines, -0 lines 0 comments Download
A + sdk/lib/_internal/lib/platform_patch.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/libraries.dart View 2 chunks +6 lines, -1 line 0 comments Download
A + sdk/lib/platform/platform.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A + sdk/lib/platform/platform_sources.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
A + tests/lib/platform/import_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Anders Johnsen
7 years, 2 months ago (2013-10-21 14:34:01 UTC) #1
ahe
I can't spot any flaws in the dart2js changes, but could you elaborate a bit ...
7 years, 2 months ago (2013-10-21 14:38:59 UTC) #2
Anders Johnsen
Sure thing, Peter: dart:platform will be a library that contains information about the runtime platform. ...
7 years, 2 months ago (2013-10-21 14:45:51 UTC) #3
ahe
Anything not in runtime, LGTM!
7 years, 2 months ago (2013-10-21 14:46:41 UTC) #4
floitsch
LGTM.
7 years, 2 months ago (2013-10-21 14:56:36 UTC) #5
Ivan Posva
On 2013/10/21 14:45:51, Anders Johnsen wrote: > Sure thing, Peter: > > dart:platform will be ...
7 years, 2 months ago (2013-10-22 00:19:53 UTC) #6
Anders Johnsen
As said above, the list is not set in stones. It's purely to get the ...
7 years, 2 months ago (2013-10-22 05:23:23 UTC) #7
kasperl
LGTM.
7 years, 2 months ago (2013-10-22 06:20:13 UTC) #8
ahe
On 2013/10/22 00:19:53, Ivan Posva wrote: > Why is the path separator not part of ...
7 years, 2 months ago (2013-10-22 09:34:03 UTC) #9
Cutch
I would like to add some SIMD acceleration flags here too.
7 years, 2 months ago (2013-10-22 10:15:13 UTC) #10
siva
The io library already sems to have a Platform class, are you planning on moving ...
7 years, 2 months ago (2013-10-22 16:18:01 UTC) #11
floitsch
On 2013/10/22 16:18:01, siva wrote: > The io library already sems to have a Platform ...
7 years, 2 months ago (2013-10-22 16:26:32 UTC) #12
Anders Johnsen
FYI, I'll land this CL as soon as I get a lgtm from the VM ...
7 years, 2 months ago (2013-10-22 19:43:00 UTC) #13
siva
The changes in general LGTM, there was one question from Ivan about why this needed ...
7 years, 2 months ago (2013-10-22 22:36:04 UTC) #14
Ivan Posva
I am failing to see the reason for adding a whole new library only to ...
7 years, 2 months ago (2013-10-23 04:34:07 UTC) #15
Ivan Posva
Florian, Thanks for the explanations. LGTM, but now we need to add some meat into ...
7 years, 2 months ago (2013-10-24 00:26:07 UTC) #16
Anders Johnsen
7 years, 2 months ago (2013-10-24 06:56:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 manually as r29154 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698