Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 326633006: polymer -- fix for ie10 (Closed)

Created:
6 years, 6 months ago by Jennifer Messerly
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

polymer -- fix for ie10 seems to be an interaction between the CE polyfill when it doesn't have __proto__, our patching of register(), and JS interop BUG= http://dartbug.com/18870 http://dartbug.com/19265 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=37150

Patch Set 1 #

Patch Set 2 : more commentary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -43 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -26 lines 0 comments Download
M pkg/polymer/lib/src/instance.dart View 1 1 chunk +9 lines, -1 line 0 comments Download
M pkg/polymer/lib/src/loader.dart View 2 chunks +11 lines, -6 lines 0 comments Download
M samples/samples.status View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
6 years, 6 months ago (2014-06-09 20:57:57 UTC) #1
Siggi Cherem (dart-lang)
wow, crazy! lgtm
6 years, 6 months ago (2014-06-09 21:42:39 UTC) #2
Jennifer Messerly
6 years, 6 months ago (2014-06-10 00:04:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r37150 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698