Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 326403010: Don't quote the arguments to xvfb (Closed)

Created:
6 years, 6 months ago by ricow1
Modified:
6 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't quote the arguments to xvfb This was stupid, this is clearly handled by passing the args, they should not be quoted R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=37273

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/bots/compiler.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
6 years, 6 months ago (2014-06-12 14:11:20 UTC) #1
Bill Hesse
lgtm
6 years, 6 months ago (2014-06-12 14:13:42 UTC) #2
ricow1
6 years, 6 months ago (2014-06-12 14:14:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r37273 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698