Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 326123002: Node cache, binary search. (Closed)

Created:
6 years, 6 months ago by scheglov
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+427 lines, -65 lines) Patch
M pkg/analysis_server/lib/src/index/b_plus_tree.dart View 7 chunks +31 lines, -15 lines 3 comments Download
A pkg/analysis_server/lib/src/index/lru_cache.dart View 1 chunk +68 lines, -0 lines 1 comment Download
M pkg/analysis_server/lib/src/index/page_node_manager.dart View 10 chunks +129 lines, -43 lines 0 comments Download
M pkg/analysis_server/test/index/file_page_manager_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A pkg/analysis_server/test/index/lru_cache_test.dart View 1 chunk +74 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/index/page_node_manager_test.dart View 6 chunks +119 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/index/test_all.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 6 months ago (2014-06-10 15:59:58 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/326123002/diff/1/pkg/analysis_server/lib/src/index/b_plus_tree.dart File pkg/analysis_server/lib/src/index/b_plus_tree.dart (right): https://codereview.chromium.org/326123002/diff/1/pkg/analysis_server/lib/src/index/b_plus_tree.dart#newcode491 pkg/analysis_server/lib/src/index/b_plus_tree.dart:491: int lo = 0; Seems like a good ...
6 years, 6 months ago (2014-06-10 17:08:29 UTC) #2
scheglov
https://codereview.chromium.org/326123002/diff/1/pkg/analysis_server/lib/src/index/b_plus_tree.dart File pkg/analysis_server/lib/src/index/b_plus_tree.dart (right): https://codereview.chromium.org/326123002/diff/1/pkg/analysis_server/lib/src/index/b_plus_tree.dart#newcode491 pkg/analysis_server/lib/src/index/b_plus_tree.dart:491: int lo = 0; On 2014/06/10 17:08:29, Brian Wilkerson ...
6 years, 6 months ago (2014-06-10 17:23:45 UTC) #3
scheglov
6 years, 6 months ago (2014-06-10 17:24:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r37188 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698