Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 325963005: Revert watcher changes for mac. (Closed)

Created:
6 years, 6 months ago by Anders Johnsen
Modified:
6 years, 5 months ago
Reviewers:
nweiz, Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Revert watcher changes for mac. We ended up with a 1.6 dependency, which I don't know if is a good idea or not. Revert "Mac no longer fire bogus events. Fix Mac watcher." Revert "Don't use kFSEventStreamCreateFlagNoDefer as it messes with event flushing." BUG= Committed: https://code.google.com/p/dart/source/detail?r=37173

Patch Set 1 #

Patch Set 2 : q #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -7 lines) Patch
M pkg/watcher/lib/src/directory_watcher/mac_os.dart View 4 chunks +67 lines, -5 lines 0 comments Download
M pkg/watcher/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Anders Johnsen
Note that this does _NOT_ revert the actual fix to the SDK.
6 years, 6 months ago (2014-06-10 12:35:40 UTC) #1
Anders Johnsen
TBR
6 years, 6 months ago (2014-06-10 12:35:48 UTC) #2
Anders Johnsen
Committed patchset #2 manually as r37173 (presubmit successful).
6 years, 6 months ago (2014-06-10 12:36:03 UTC) #3
Søren Gjesse
lgtm
6 years, 6 months ago (2014-06-10 12:45:27 UTC) #4
kevmoo
On 2014/06/10 12:45:27, Søren Gjesse wrote: > lgtm Anders: would you open an issue to ...
6 years, 6 months ago (2014-06-10 18:32:10 UTC) #5
kevmoo
On 2014/06/10 18:32:10, kevmoo wrote: > On 2014/06/10 12:45:27, Søren Gjesse wrote: > > lgtm ...
6 years, 5 months ago (2014-07-07 19:38:48 UTC) #6
nweiz
6 years, 5 months ago (2014-07-07 19:47:05 UTC) #7
Message was sent while issue was closed.
On 2014/07/07 19:38:48, kevmoo wrote:
> On 2014/06/10 18:32:10, kevmoo wrote:
> > On 2014/06/10 12:45:27, Søren Gjesse wrote:
> > > lgtm
> > 
> > Anders: would you open an issue to track this?
> > 
> > Once we change the build tools/VERSION to be 1.6, we can add a pre-release
> > version constraint without a problem
> 
> We can run w/ this fix now, right? Just add the 1.6-dev (or whatever) version
> constraint?

I don't understand why this was reverted in the first place. It's always safe to
release a version with a narrow SDK constraint; pub simply won't select it on
older SDKs.

Powered by Google App Engine
This is Rietveld 408576698