Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 32593007: fix todomvc tests (Closed)

Created:
7 years, 2 months ago by Jennifer Messerly
Modified:
7 years, 2 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M samples/samples.status View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 4 chunks +6 lines, -4 lines 0 comments Download
M tools/dom/src/dart2js_CustomElementSupport.dart View 1 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
The only test that was still failing was markdone_shadow_test, which forces Shadow DOM polyfill, so ...
7 years, 2 months ago (2013-10-21 23:03:14 UTC) #1
sra1
lgtm
7 years, 2 months ago (2013-10-22 19:11:49 UTC) #2
Jennifer Messerly
7 years, 2 months ago (2013-10-22 20:14:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r29032 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698