Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 325923003: Add back invalid natives that couldn't be removed due to analyzer warnings. (Closed)

Created:
6 years, 6 months ago by Jacob
Modified:
6 years, 6 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Add back invalid natives that couldn't be removed due to analyzer warnings. BUG= R=leafp@google.com Committed: https://code.google.com/p/dart/source/detail?r=37146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/dom/idl/dart/dart.idl View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jacob
6 years, 6 months ago (2014-06-09 23:17:32 UTC) #1
Leaf
lgtm
6 years, 6 months ago (2014-06-09 23:19:27 UTC) #2
Jacob
6 years, 6 months ago (2014-06-09 23:19:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37146 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698