Issue 325473002: Add intern support to analyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 325473002: Add intern support to analyzer (Closed)

Created:
6 years, 6 months ago by Brian Wilkerson

Modified:
6 years, 6 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org, devoncarew

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add intern support to analyzer. In tests, this reduces the memory requirements for engine by about 15%. I have only enabled it for the command-line analyzer, though, because other uses will need to guard against memory leaks. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=37112

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -2 lines)			Patch
A	editor/util/plugins/com.google.dart.java2dart/resources/interner.dart	View	1 chunk	+49 lines, -0 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/resources/java_engine.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/bin/analyzer.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	pkg/analyzer/lib/src/generated/interner.dart	View	1 chunk	+49 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/java_engine.dart	View	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

6 years, 6 months ago (2014-06-07 15:57:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r37112 (presubmit successful).

Expand Messages | Collapse Messages