Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1491)

Issue 32523007: Revert "Removing some deprecated members" (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Removing some deprecated members" For some reason this broke indexed_db on Dartium, I debugged in some but need more time to understand. The completed event is not firing. TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=29033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1270 lines, -246 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 49 chunks +444 lines, -7 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 118 chunks +588 lines, -114 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 3 chunks +66 lines, -0 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 7 chunks +70 lines, -4 lines 0 comments Download
M tests/html/html.status View 7 chunks +7 lines, -0 lines 0 comments Download
A tests/html/notifications_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download
M tools/dom/dom.json View 20 chunks +23 lines, -93 lines 0 comments Download
M tools/dom/scripts/dartdomgenerator.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 5 chunks +14 lines, -9 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_EventTarget.darttemplate View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
blois
7 years, 2 months ago (2013-10-22 20:20:45 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r29033 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698