Issue 32513007: Allow string literal concatenation in import clauses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 32513007: Allow string literal concatenation in import clauses (Closed)

Created:
7 years, 2 months ago by hausner

Modified:
7 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Allow string literal concatenation in import clauses Added benefit: if there is no interpolation in any of the adjacent string literals, the compiler concatenates the strings without invoking Dart code. Fixes issues 12521, 6877 R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=28964

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -22 lines)			Patch
M	runtime/vm/parser.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	7 chunks	+28 lines, -7 lines	0 comments	Download
M	tests/co19/co19-dartium.status	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

7 years, 2 months ago (2013-10-21 22:13:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r28964 (presubmit successful).

Expand Messages | Collapse Messages