Issue 324623002: Create/read/write/delete nodes using NodeManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 324623002: Create/read/write/delete nodes using NodeManager. (Closed)

Created:
6 years, 6 months ago by scheglov

Modified:
6 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Create/read/write/delete nodes using NodeManager. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37116

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+413 lines, -128 lines)			Patch
	M	pkg/analysis_server/lib/src/index/b_plus_tree.dart	View		14 chunks	+397 lines, -122 lines	1 comment	Download
	M	pkg/analysis_server/test/index/b_plus_tree_test.dart	View		8 chunks	+16 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/324623002/diff/1/pkg/analysis_server/lib/src/index/b_plus_tree.dart File pkg/analysis_server/lib/src/index/b_plus_tree.dart (right): https://codereview.chromium.org/324623002/diff/1/pkg/analysis_server/lib/src/index/b_plus_tree.dart#newcode295 pkg/analysis_server/lib/src/index/b_plus_tree.dart:295: class _IndexNode<K, V, N> extends _Node<K, V, N> ...

6 years, 6 months ago (2014-06-08 16:50:06 UTC) #2

scheglov

6 years, 6 months ago (2014-06-08 17:07:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r37116 (presubmit successful).

Expand Messages | Collapse Messages