Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 324433003: In SnapshotReader, changes BackRefNode to be a ValueObject. (Closed)

Created:
6 years, 6 months ago by zra
Modified:
6 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

In SnapshotReader, changes BackRefNode to be a ValueObject. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37093

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M runtime/vm/snapshot.h View 3 chunks +8 lines, -4 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 4 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zra
6 years, 6 months ago (2014-06-06 17:27:21 UTC) #1
siva
lgtm https://codereview.chromium.org/324433003/diff/1/runtime/vm/snapshot.cc File runtime/vm/snapshot.cc (right): https://codereview.chromium.org/324433003/diff/1/runtime/vm/snapshot.cc#newcode21 runtime/vm/snapshot.cc:21: #define I (isolate()) Is this still needed?
6 years, 6 months ago (2014-06-06 18:10:33 UTC) #2
zra
https://codereview.chromium.org/324433003/diff/1/runtime/vm/snapshot.cc File runtime/vm/snapshot.cc (right): https://codereview.chromium.org/324433003/diff/1/runtime/vm/snapshot.cc#newcode21 runtime/vm/snapshot.cc:21: #define I (isolate()) On 2014/06/06 18:10:33, siva wrote: > ...
6 years, 6 months ago (2014-06-06 18:30:58 UTC) #3
zra
6 years, 6 months ago (2014-06-06 18:31:10 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r37093 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698