Issue 324083005: Add 'resetInteractions' into typed_mock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 324083005: Add 'resetInteractions' into typed_mock. (Closed)

Created:
6 years, 6 months ago by scheglov

Modified:
6 years, 6 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add 'resetInteractions' into typed_mock. 1. I decided not to change the verifyZeroInteractions(TypedMock) API. There is an advantage in having it typed, such as (potentially) improved code completion. The drawback is that tests have to use MyClassMock type annotatino instead of MyClass. But TypedMock does not have any API, so it should not be a big problem. 2. It is impossible to distinguish 'get:foo' access from taking a reference to a method or property invocation. I guess it is intentional. We could probably distinguish them using mirrors, but typed_mock should work without mirrors. So, resetInteractions() should be used. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37191

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -1 line)			Patch
M	pkg/typed_mock/lib/typed_mock.dart	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	pkg/typed_mock/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/typed_mock/test/typed_mock_test.dart	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

6 years, 6 months ago (2014-06-10 18:23:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r37191 (presubmit successful).

Expand Messages | Collapse Messages