Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 323703002: Flush stderr when printing ASSERT message. (Closed)

Created:
6 years, 6 months ago by Anders Johnsen
Modified:
6 years, 6 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, ricow1
Visibility:
Public.

Description

Flush stderr when printing ASSERT message. This ensures that the message is received by the other end, e.g. test.dart, on Windows. BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M runtime/platform/assert.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 6 months ago (2014-06-07 12:49:02 UTC) #1
Ivan Posva
LGTM -ip
6 years, 6 months ago (2014-06-09 20:48:57 UTC) #2
Anders Johnsen
6 years, 6 months ago (2014-06-10 06:52:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37160 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698