Issue 32363003: Handle resolution of Class.named<TypeArg> correctly.

Issue 32363003: Handle resolution of Class.named<TypeArg> correctly. (Closed)

Created:
7 years, 2 months ago by Johnni Winther

Modified:
7 years, 2 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle resolution of Class.named<TypeArg> correctly. BUG= R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=28984

Patch Set 2 : Remove debug code. #

Total comments: 4

Patch Set 4 : Updated cf. comments. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -19 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2 3	3 chunks	+11 lines, -16 lines	0 comments	Download
M	sdk/lib/_internal/lib/isolate_helper.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	tests/language/named_constructor_lib.dart	View		1 chunk	+5 lines, -2 lines	0 comments	Download
A	tests/language/named_constructor_test.dart	View	1 2 3	1 chunk	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/32363003/diff/30001/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/32363003/diff/30001/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode1637 sdk/lib/_internal/compiler/implementation/resolution/members.dart:1637: // The caller creates the ErroneousElement for the ...

7 years, 2 months ago (2013-10-21 13:28:56 UTC) #2

Johnni Winther

Committed patchset #4 manually as r28984 (presubmit successful).

7 years, 2 months ago (2013-10-22 06:17:18 UTC) #3

Johnni Winther

7 years, 2 months ago (2013-10-22 06:25:53 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/32363003/diff/30001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/32363003/diff/30001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1637: // The
caller creates the ErroneousElement for the MalformedType.
On 2013/10/21 13:28:56, ngeoffray wrote:
> caller creates -> the caller of this method will create ?

Done.

https://codereview.chromium.org/32363003/diff/30001/tests/language/named_cons...
File tests/language/named_constructor_test.dart (right):

https://codereview.chromium.org/32363003/diff/30001/tests/language/named_cons...
tests/language/named_constructor_test.dart:1: library named_constructor_test;
On 2013/10/21 13:28:56, ngeoffray wrote:
> Missing copyright.

Done.

Expand Messages | Collapse Messages