Issue 323163002: Adds an assertion to limit snapshot intptr_t size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 323163002: Adds an assertion to limit snapshot intptr_t size. (Closed)

Created:
6 years, 6 months ago by zra

Modified:
6 years, 6 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Adds an assertion to limit snapshot intptr_t size. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37196

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
M	runtime/vm/dart_api_message.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/snapshot.h	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM with one comment. https://codereview.chromium.org/323163002/diff/1/runtime/vm/dart_api_message.cc File runtime/vm/dart_api_message.cc (right): https://codereview.chromium.org/323163002/diff/1/runtime/vm/dart_api_message.cc#newcode1159 runtime/vm/dart_api_message.cc:1159: WriteRawPointerValue(reinterpret_cast<intptr_t>(callback)); Would be symmetric to ...

6 years, 6 months ago (2014-06-10 19:51:37 UTC) #2

zra

https://codereview.chromium.org/323163002/diff/1/runtime/vm/dart_api_message.cc File runtime/vm/dart_api_message.cc (right): https://codereview.chromium.org/323163002/diff/1/runtime/vm/dart_api_message.cc#newcode1159 runtime/vm/dart_api_message.cc:1159: WriteRawPointerValue(reinterpret_cast<intptr_t>(callback)); On 2014/06/10 19:51:37, siva wrote: > Would be ...

6 years, 6 months ago (2014-06-10 20:15:38 UTC) #3

zra

6 years, 6 months ago (2014-06-10 20:15:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r37196 (presubmit successful).

Expand Messages | Collapse Messages

Issue 323163002: Adds an assertion to limit snapshot intptr_t size. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages