Cache version list results even when they fail.

Cache version list results even when they fail.

BUG=https://code.google.com/p/dart/issues/detail?id=14346
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37212

[Bob Nystrom, 2014-06-10 19:56:13]

I don't know if this will actually fix the test that's timing out, but this has
been annoying me for a while.

Basically, pub makes sure the cache the results of a version list query so that
it only requests a given package once. However, if the call fails, it doesn't
cache that. That means it can end up doing multiple requests if the first one
fails.

This fixes that.

[nweiz, 2014-06-10 20:34:09]

lgtm

https://codereview.chromium.org/323073006/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/solver/version_solver.dart (right):

https://codereview.chromium.org/323073006/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/solver/version_solver.dart:115: final
_versionErrors = new Map<PackageRef, Pair>();
Pair of what?

https://codereview.chromium.org/323073006/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/solver/version_solver.dart:204: log.solver("Could
not get versions for $package:\n$error\n\n$trace");
Chain-ify the stack trace before logging it. Also usually we just put one
newline between the error message and its stack trace.

[Bob Nystrom, 2014-06-10 23:23:31]

Committed patchset #3 manually as r37212 (presubmit successful).

[Bob Nystrom, 2014-11-10 22:13:53]

Never sent these out.

https://codereview.chromium.org/323073006/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/solver/version_solver.dart (right):

https://codereview.chromium.org/323073006/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/solver/version_solver.dart:115: final
_versionErrors = new Map<PackageRef, Pair>();
On 2014/06/10 20:34:09, nweiz wrote:
> Pair of what?

Errors and stacks, so I guess <Object, StackTrace>? Changed to that.

https://codereview.chromium.org/323073006/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/solver/version_solver.dart:204: log.solver("Could
not get versions for $package:\n$error\n\n$trace");
On 2014/06/10 20:34:09, nweiz wrote:
> Chain-ify the stack trace before logging it. Also usually we just put one
> newline between the error message and its stack trace.

Done.

[nweiz, 2014-11-11 02:25:05]

lgtm