Issue 322633002: Share ic data between unoptimized and optimized static calls.

Issue 322633002: Share ic data between unoptimized and optimized static calls. (Closed)

Created:
6 years, 6 months ago by regis

Modified:
6 years, 6 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Share ic data between unoptimized and optimized static calls. This prevents duplicated javascript compatibility warnings. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37103

Total comments: 4

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -130 lines)			Patch
M	runtime/vm/flow_graph_compiler.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View		1 chunk	+19 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View		1 chunk	+2 lines, -18 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View		1 chunk	+2 lines, -18 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		1 chunk	+2 lines, -18 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View		1 chunk	+2 lines, -18 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View		1 chunk	+2 lines, -18 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		2 chunks	+22 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		3 chunks	+7 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	tests/standalone/javascript_compatibility_errors_test.dart	View	1	1 chunk	+12 lines, -10 lines	0 comments	Download

Total messages: 4 (0 generated)

srdjan

LGTM. Do you have tests that check that the warning is emitted only once (in ...

6 years, 6 months ago (2014-06-06 21:19:37 UTC) #2

regis

Thanks! Good suggestion on checking that warnings are only issued once. I modified the test ...

6 years, 6 months ago (2014-06-06 21:47:16 UTC) #3

regis

6 years, 6 months ago (2014-06-06 21:47:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r37103 (presubmit successful).