Issue 322563002: Formatter: fix for long multiline strings.

Issue 322563002: Formatter: fix for long multiline strings. (Closed)

Created:
6 years, 6 months ago by scheglov

Modified:
6 years, 6 months ago

Reviewers:
pquitslund, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Formatter: fix for long multiline strings. R=brianwilkerson@google.com, pquitslund@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37088

Patch Set 2 : Fixes for review comments. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -2 lines)			Patch
	M	pkg/analyzer/lib/src/services/writer.dart	View	1	1 chunk	+12 lines, -2 lines	0 comments	Download
	M	pkg/analyzer/test/services/formatter_test.dart	View	1	2 chunks	+54 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pquitslund

LGTM % nit on type annotations. https://codereview.chromium.org/322563002/diff/1/pkg/analyzer/lib/src/services/writer.dart File pkg/analyzer/lib/src/services/writer.dart (right): https://codereview.chromium.org/322563002/diff/1/pkg/analyzer/lib/src/services/writer.dart#newcode354 pkg/analyzer/lib/src/services/writer.dart:354: List<String> lines = ...

6 years, 6 months ago (2014-06-06 17:18:53 UTC) #2

Brian Wilkerson

LGTM https://codereview.chromium.org/322563002/diff/1/pkg/analyzer/test/services/formatter_test.dart File pkg/analyzer/test/services/formatter_test.dart (right): https://codereview.chromium.org/322563002/diff/1/pkg/analyzer/test/services/formatter_test.dart#newcode1022 pkg/analyzer/test/services/formatter_test.dart:1022: ' print("""\n' indentation?

6 years, 6 months ago (2014-06-06 17:23:54 UTC) #3

scheglov

https://codereview.chromium.org/322563002/diff/1/pkg/analyzer/lib/src/services/writer.dart File pkg/analyzer/lib/src/services/writer.dart (right): https://codereview.chromium.org/322563002/diff/1/pkg/analyzer/lib/src/services/writer.dart#newcode354 pkg/analyzer/lib/src/services/writer.dart:354: List<String> lines = string.split(lineSeparator); On 2014/06/06 17:18:53, pquitslund wrote: ...

6 years, 6 months ago (2014-06-06 17:25:37 UTC) #4

scheglov

6 years, 6 months ago (2014-06-06 17:26:00 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r37088 (presubmit successful).

Expand Messages | Collapse Messages