Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 32253003: fix analyzer issue in listorder_test (Closed)

Created:
7 years, 2 months ago by Jennifer Messerly
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix analyzer issue in listorder_test also fix polymer test/run.sh to test analyzer again Committed: https://code.google.com/p/dart/source/detail?r=28962

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M pkg/polymer/test/run.sh View 1 chunk +6 lines, -1 line 0 comments Download
M samples/third_party/todomvc/test/listorder_test.dart View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
TBR for bots
7 years, 2 months ago (2013-10-21 22:08:08 UTC) #1
Jennifer Messerly
Committed patchset #1 manually as r28962 (presubmit successful).
7 years, 2 months ago (2013-10-21 22:08:24 UTC) #2
Jennifer Messerly
fyi, it appears all of TodoMVC tests are disabled in samples.status on all browser configurations ...
7 years, 2 months ago (2013-10-21 22:10:24 UTC) #3
Siggi Cherem (dart-lang)
7 years, 2 months ago (2013-10-21 22:10:47 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698