Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 321953002: FilePageManager - disk based PageManager. (Closed)

Created:
6 years, 6 months ago by scheglov
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Improved tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -11 lines) Patch
M pkg/analysis_server/lib/src/index/b_plus_tree.dart View 4 chunks +20 lines, -4 lines 0 comments Download
A pkg/analysis_server/lib/src/index/file_page_manager.dart View 1 1 chunk +84 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/index/page_node_manager.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/index/b_plus_tree_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analysis_server/test/index/file_page_manager_test.dart View 1 1 chunk +118 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/index/page_node_manager_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/index/test_all.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 6 months ago (2014-06-09 22:22:59 UTC) #1
Brian Wilkerson
LGTM
6 years, 6 months ago (2014-06-10 00:08:07 UTC) #2
scheglov
6 years, 6 months ago (2014-06-10 05:51:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r37158 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698