Censor dart:_blink and dart:builtin from the enumeration of libraries in the isolate and from impor…

Censor dart:_blink and dart:builtin from the enumeration of libraries in the isolate and from import lists. Note we are not censoring dart:_internal.

For the moment, this doesn't seem to break any language invariants, but that may happen if
a) the censored libraries start producing instances, whose classes would claim to have no library
b) types from the censored libraries are used in type annotations in the privileged libraries that can import them, resulting in types other than dynamic that claim to belong to no library

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37238

[rmacnak, 2014-06-10 22:32:56]

RFC

[Jacob, 2014-06-11 04:35:43]

I think Dart_GetLibraryIds should also censor these libraries.

[Jacob, 2014-06-11 04:49:56]

On 2014/06/11 04:35:43, Jacob wrote:
> I think Dart_GetLibraryIds should also censor these libraries.

As some context, that is the method the devtools currently use to get the list
of libraries and we clearly don't want the devtools showing these censored
libraries to the user.

[Ivan Posva, 2014-06-11 17:56:39]

LGTM

This will need a bit more complete assessment as to what can be accessed through
reflection. A discussion best to be had when designing and implementing the new
reflective APIs.

-Ivan

[rmacnak, 2014-06-11 17:58:24]

Committed patchset #1 manually as r37238 (presubmit successful).

[kasperl, 2014-06-12 07:45:16]

Is this something we should merge to trunk to fix dartbug.com/19331? Please file
a merge request if so.