Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 321133002: Don't use kFSEventStreamCreateFlagNoDefer as it messes with event flushing. (Closed)

Created:
6 years, 6 months ago by Anders Johnsen
Modified:
6 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org, nweiz, Bob Nystrom
Visibility:
Public.

Description

Don't use kFSEventStreamCreateFlagNoDefer as it messes with event flushing. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=37171

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/watcher/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/file_system_watcher_macos.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
6 years, 6 months ago (2014-06-10 07:46:11 UTC) #1
Anders Johnsen
With this flag gone, I can no longer repro any issues.
6 years, 6 months ago (2014-06-10 07:46:42 UTC) #2
Søren Gjesse
lgtm
6 years, 6 months ago (2014-06-10 10:43:27 UTC) #3
Anders Johnsen
6 years, 6 months ago (2014-06-10 10:44:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r37171 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698