Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 319983005: pkg/unittest: test cleanup (Closed)

Created:
6 years, 6 months ago by kevmoo
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -1202 lines) Patch
M pkg/pkg.status View 1 2 chunks +25 lines, -25 lines 0 comments Download
M pkg/unittest/CHANGELOG.md View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/unittest/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/unittest/test/async_exception_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
A + pkg/unittest/test/async_setup_teardown_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/unittest/test/breath_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
A + pkg/unittest/test/completion_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A + pkg/unittest/test/correct_callback_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A + pkg/unittest/test/exception_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A + pkg/unittest/test/excess_callback_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A + pkg/unittest/test/expect_async_args_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A + pkg/unittest/test/expect_async_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A + pkg/unittest/test/group_name_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
D pkg/unittest/test/instance_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
A + pkg/unittest/test/invalid_ops_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A + pkg/unittest/test/late_exception_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A + pkg/unittest/test/middle_exception_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/unittest/test/missing_tick_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
A + pkg/unittest/test/nested_groups_setup_teardown_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A + pkg/unittest/test/protect_async_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A + pkg/unittest/test/returning_future_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A + pkg/unittest/test/returning_future_using_runasync_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
A + pkg/unittest/test/runtests_without_tests_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A + pkg/unittest/test/setup_and_teardown_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A + pkg/unittest/test/setup_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
A + pkg/unittest/test/single_correct_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A + pkg/unittest/test/single_failing_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A + pkg/unittest/test/skipped_soloed_nested_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A + pkg/unittest/test/teardown_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
D pkg/unittest/test/test_common.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D pkg/unittest/test/test_utils.dart View 1 chunk +0 lines, -81 lines 0 comments Download
A + pkg/unittest/test/testcases_immutable_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
D pkg/unittest/test/unittest_async_exception_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D pkg/unittest/test/unittest_async_setup_teardown_test.dart View 1 chunk +0 lines, -64 lines 0 comments Download
D pkg/unittest/test/unittest_completion_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D pkg/unittest/test/unittest_correct_callback_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D pkg/unittest/test/unittest_exception_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D pkg/unittest/test/unittest_excess_callback_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D pkg/unittest/test/unittest_expect_async_args_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D pkg/unittest/test/unittest_expect_async_test.dart View 1 chunk +0 lines, -95 lines 0 comments Download
D pkg/unittest/test/unittest_group_name_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/unittest/test/unittest_invalid_ops_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D pkg/unittest/test/unittest_late_exception_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D pkg/unittest/test/unittest_middle_exception_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D pkg/unittest/test/unittest_nested_groups_setup_teardown_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D pkg/unittest/test/unittest_protect_async_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D pkg/unittest/test/unittest_runtests_without_tests_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D pkg/unittest/test/unittest_setup_and_teardown_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/unittest/test/unittest_setup_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/unittest/test/unittest_single_correct_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D pkg/unittest/test/unittest_single_failing_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D pkg/unittest/test/unittest_skipped_soloed_nested_test.dart View 1 chunk +0 lines, -76 lines 0 comments Download
D pkg/unittest/test/unittest_teardown_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D pkg/unittest/test/unittest_test_returning_future_test.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D pkg/unittest/test/unittest_test_returning_future_using_runasync_test.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D pkg/unittest/test/unittest_test_utils.dart View 1 chunk +0 lines, -93 lines 0 comments Download
D pkg/unittest/test/unittest_testcases_immutable_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
A + pkg/unittest/test/utils.dart View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo
There were test files left over from pkg/matcher Now that the one remaining test has ...
6 years, 6 months ago (2014-06-06 23:04:08 UTC) #1
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/319983005/diff/1/pkg/unittest/test/completion_test.dart File pkg/unittest/test/completion_test.dart (right): https://codereview.chromium.org/319983005/diff/1/pkg/unittest/test/completion_test.dart#newcode5 pkg/unittest/test/completion_test.dart:5: library unittestTest; I just noticed that this is ...
6 years, 6 months ago (2014-06-09 23:22:29 UTC) #2
kevmoo
On 2014/06/09 23:22:29, Siggi Cherem (dart-lang) wrote: > lgtm > > https://codereview.chromium.org/319983005/diff/1/pkg/unittest/test/completion_test.dart > File pkg/unittest/test/completion_test.dart ...
6 years, 6 months ago (2014-06-09 23:39:34 UTC) #3
kevmoo
6 years, 6 months ago (2014-06-09 23:40:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r37147 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698