Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 31993005: Remove Platform.upgrateCustomElements. (Closed)

Created:
7 years, 2 months ago by Emily Fortuna
Modified:
7 years, 2 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove Platform.upgrateCustomElements. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=28947

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -63 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +0 lines, -13 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +2 lines, -14 lines 0 comments Download
M tests/html/custom/created_callback_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/html/custom/document_register_basic_test.dart View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M tests/html/custom/document_register_type_extensions_test.dart View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M tests/html/custom/entered_left_view_test.dart View 1 5 chunks +5 lines, -5 lines 0 comments Download
M tests/html/custom_elements_test.dart View 1 2 5 chunks +5 lines, -4 lines 0 comments Download
M tests/html/utils.dart View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M tools/dom/src/dart2js_Platform.dart View 1 chunk +0 lines, -13 lines 0 comments Download
M tools/dom/src/dartium_Platform.dart View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
Fix for https://code.google.com/p/dart/issues/detail?id=14245 What's the context for this change?
7 years, 2 months ago (2013-10-21 17:53:23 UTC) #1
blois
lgtm We added it as a way to force custom elements to be upgraded synchronously ...
7 years, 2 months ago (2013-10-21 17:57:06 UTC) #2
Emily Fortuna
7 years, 2 months ago (2013-10-21 20:21:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r28947 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698