Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 319523004: Outline notification implementation in server. (Closed)

Created:
6 years, 6 months ago by scheglov
Modified:
6 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Outline notification implementation in server. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37025

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1092 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +15 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/computer/computer_outline.dart View 1 chunk +366 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 6 chunks +19 lines, -0 lines 2 comments Download
A pkg/analysis_server/test/analysis_notification_outline_test.dart View 1 chunk +679 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 6 months ago (2014-06-04 22:24:28 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/319523004/diff/1/pkg/analysis_server/lib/src/operation/operation_analysis.dart File pkg/analysis_server/lib/src/operation/operation_analysis.dart (right): https://codereview.chromium.org/319523004/diff/1/pkg/analysis_server/lib/src/operation/operation_analysis.dart#newcode91 pkg/analysis_server/lib/src/operation/operation_analysis.dart:91: I don't actually like having two blank lines ...
6 years, 6 months ago (2014-06-04 23:53:59 UTC) #2
scheglov
https://codereview.chromium.org/319523004/diff/1/pkg/analysis_server/lib/src/operation/operation_analysis.dart File pkg/analysis_server/lib/src/operation/operation_analysis.dart (right): https://codereview.chromium.org/319523004/diff/1/pkg/analysis_server/lib/src/operation/operation_analysis.dart#newcode91 pkg/analysis_server/lib/src/operation/operation_analysis.dart:91: On 2014/06/04 23:54:00, Brian Wilkerson wrote: > I don't ...
6 years, 6 months ago (2014-06-05 01:37:50 UTC) #3
scheglov
6 years, 6 months ago (2014-06-05 01:38:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r37025 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698