Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 319493005: - Re-add the assert which was removed in r36993. (Closed)

Created:
6 years, 6 months ago by Ivan Posva
Modified:
6 years, 6 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Re-add the assert which was removed in r36993. - Add dummy alignment field until we have a better way to deal with the growable objects on Windows. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37015

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M runtime/vm/object.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
6 years, 6 months ago (2014-06-04 21:17:36 UTC) #1
srdjan
lgtm
6 years, 6 months ago (2014-06-04 21:18:19 UTC) #2
Ivan Posva
6 years, 6 months ago (2014-06-04 21:18:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37015 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698