Issue 319433003: Mac no longer fire bogus events. Fix Mac watcher.

Issue 319433003: Mac no longer fire bogus events. Fix Mac watcher. (Closed)

Created:
6 years, 6 months ago by Anders Johnsen

Modified:
6 years, 6 months ago

Reviewers:
nweiz, Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mac no longer fire bogus events. Fix Mac watcher. BUG= R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=37162

Patch Set 2 : #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -69 lines)			Patch
	M	pkg/watcher/lib/src/directory_watcher/mac_os.dart	View		4 chunks	+5 lines, -67 lines	0 comments	Download
	M	pkg/watcher/pubspec.yaml	View	1	2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/319433003/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart File pkg/watcher/lib/src/directory_watcher/mac_os.dart (left): https://codereview.chromium.org/319433003/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart#oldcode77 pkg/watcher/lib/src/directory_watcher/mac_os.dart:77: /// events (see issue 14373). Update this issue ...

6 years, 6 months ago (2014-06-09 19:17:41 UTC) #2

kevmoo

On 2014/06/09 19:17:41, nweiz wrote: > lgtm > > https://codereview.chromium.org/319433003/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart > File pkg/watcher/lib/src/directory_watcher/mac_os.dart (left): > ...

6 years, 6 months ago (2014-06-09 21:38:01 UTC) #3

nweiz

On 2014/06/09 21:38:01, kevmoo wrote: > On 2014/06/09 19:17:41, nweiz wrote: > > lgtm > ...

6 years, 6 months ago (2014-06-10 00:46:41 UTC) #4

Anders Johnsen

Committed patchset #2 manually as r37162 (presubmit successful).

6 years, 6 months ago (2014-06-10 07:04:17 UTC) #5

Anders Johnsen

I've updated the pubspec.yaml file. https://codereview.chromium.org/319433003/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart File pkg/watcher/lib/src/directory_watcher/mac_os.dart (left): https://codereview.chromium.org/319433003/diff/1/pkg/watcher/lib/src/directory_watcher/mac_os.dart#oldcode77 pkg/watcher/lib/src/directory_watcher/mac_os.dart:77: /// events (see issue ...

6 years, 6 months ago (2014-06-10 07:09:40 UTC) #6

nweiz

6 years, 6 months ago (2014-06-10 19:22:16 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/319433003/diff/20001/pkg/watcher/pubspec.yaml
File pkg/watcher/pubspec.yaml (right):

https://codereview.chromium.org/319433003/diff/20001/pkg/watcher/pubspec.yaml...
pkg/watcher/pubspec.yaml:2: version: 0.9.4-dev
This number doesn't need to be updated. The "-dev" suffix means that 0.9.3
hasn't been released yet. See
https://docs.google.com/a/google.com/document/d/1kPhEF8rL53S45SpzboyddKW61EUn...
for details.

Expand Messages | Collapse Messages