Expose the HttpRequest object in HttpRequestBody, making all request properties available.

Expose the HttpRequest object in HttpRequestBody, making all request properties available.

BUG=https://code.google.com/p/dart/issues/detail?id=14259
R=sethladd@google.com, sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28919

[sethladd, 2013-10-21 07:37:43]

just what I needed :)

lgtm

https://codereview.chromium.org/31813002/diff/30001/pkg/http_server/lib/src/h...
File pkg/http_server/lib/src/http_body.dart (right):

https://codereview.chromium.org/31813002/diff/30001/pkg/http_server/lib/src/h...
pkg/http_server/lib/src/http_body.dart:172: * contains access to the request,
for reading all request header information
"contains access" is a bit clunky. perhaps "provides access" ?

[Søren Gjesse, 2013-10-21 07:44:08]

lgtm, nice cleanup

https://codereview.chromium.org/31813002/diff/30001/pkg/http_server/lib/src/h...
File pkg/http_server/lib/src/http_body.dart (right):

https://codereview.chromium.org/31813002/diff/30001/pkg/http_server/lib/src/h...
pkg/http_server/lib/src/http_body.dart:177: * The [HttpRequest] from which the
[HttpRequestBody] was created.
Maybe add a comment that the request body is (of cause) drained and the stream
methods can not be used.

[Anders Johnsen, 2013-10-21 08:06:56]

Thanks, landing.

https://codereview.chromium.org/31813002/diff/30001/pkg/http_server/lib/src/h...
File pkg/http_server/lib/src/http_body.dart (right):

https://codereview.chromium.org/31813002/diff/30001/pkg/http_server/lib/src/h...
pkg/http_server/lib/src/http_body.dart:172: * contains access to the request,
for reading all request header information
On 2013/10/21 07:37:43, sethladd wrote:
> "contains access" is a bit clunky. perhaps "provides access" ?

Done.

https://codereview.chromium.org/31813002/diff/30001/pkg/http_server/lib/src/h...
pkg/http_server/lib/src/http_body.dart:177: * The [HttpRequest] from which the
[HttpRequestBody] was created.
On 2013/10/21 07:44:08, Søren Gjesse wrote:
> Maybe add a comment that the request body is (of cause) drained and the stream
> methods can not be used.

Done.

[Anders Johnsen, 2013-10-21 08:07:19]

Committed patchset #3 manually as r28919 (presubmit successful).