Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 318053002: Update SourceMapViewer to work on Windows. (Closed)

Created:
6 years, 6 months ago by Johnni Winther
Modified:
6 years, 6 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org, ricow1, zarah
Visibility:
Public.

Description

Update SourceMapViewer to work on Windows. BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=37169

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M tools/dart2js/sourceMapViewer/README.TXT View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tools/dart2js/sourceMapViewer/bin/source_map_viewer.dart View 1 5 chunks +17 lines, -13 lines 0 comments Download
M tools/dart2js/sourceMapViewer/web/display.html View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Johnni Winther
6 years, 6 months ago (2014-06-06 08:19:10 UTC) #1
sigurdm
lgtm https://codereview.chromium.org/318053002/diff/1/tools/dart2js/sourceMapViewer/bin/source_map_viewer.dart File tools/dart2js/sourceMapViewer/bin/source_map_viewer.dart (right): https://codereview.chromium.org/318053002/diff/1/tools/dart2js/sourceMapViewer/bin/source_map_viewer.dart#newcode83 tools/dart2js/sourceMapViewer/bin/source_map_viewer.dart:83: String root = fromUri(Platform.script.resolve('../build/web/')); If I forget to ...
6 years, 6 months ago (2014-06-06 08:55:45 UTC) #2
sigurdm
https://codereview.chromium.org/318053002/diff/1/tools/dart2js/sourceMapViewer/web/display.html File tools/dart2js/sourceMapViewer/web/display.html (left): https://codereview.chromium.org/318053002/diff/1/tools/dart2js/sourceMapViewer/web/display.html#oldcode41 tools/dart2js/sourceMapViewer/web/display.html:41: <div id="generated_output" style="border:2px solid;overflow:scroll;width:550px;height:50px;"></div> One more thing - all ...
6 years, 6 months ago (2014-06-06 08:59:10 UTC) #3
Johnni Winther
https://codereview.chromium.org/318053002/diff/1/tools/dart2js/sourceMapViewer/bin/source_map_viewer.dart File tools/dart2js/sourceMapViewer/bin/source_map_viewer.dart (right): https://codereview.chromium.org/318053002/diff/1/tools/dart2js/sourceMapViewer/bin/source_map_viewer.dart#newcode83 tools/dart2js/sourceMapViewer/bin/source_map_viewer.dart:83: String root = fromUri(Platform.script.resolve('../build/web/')); On 2014/06/06 08:55:45, sigurdm wrote: ...
6 years, 6 months ago (2014-06-10 09:23:27 UTC) #4
Johnni Winther
6 years, 6 months ago (2014-06-10 09:30:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r37169 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698