Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 317633007: Report 500 errors more gracefully. (Closed)

Created:
6 years, 6 months ago by Bob Nystrom
Modified:
6 years, 6 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Report 500 errors more gracefully. BUG=https://code.google.com/p/dart/issues/detail?id=18828 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=37034

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove debug code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M sdk/lib/_internal/pub/lib/src/http.dart View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bob Nystrom
6 years, 6 months ago (2014-06-04 22:48:04 UTC) #1
nweiz
https://codereview.chromium.org/317633007/diff/1/sdk/lib/_internal/pub/lib/src/http.dart File sdk/lib/_internal/pub/lib/src/http.dart (right): https://codereview.chromium.org/317633007/diff/1/sdk/lib/_internal/pub/lib/src/http.dart#newcode91 sdk/lib/_internal/pub/lib/src/http.dart:91: request.url.host == "storage.googleapis.com")) { Shouldn't this also check for ...
6 years, 6 months ago (2014-06-05 00:25:41 UTC) #2
Bob Nystrom
https://codereview.chromium.org/317633007/diff/1/sdk/lib/_internal/pub/lib/src/http.dart File sdk/lib/_internal/pub/lib/src/http.dart (right): https://codereview.chromium.org/317633007/diff/1/sdk/lib/_internal/pub/lib/src/http.dart#newcode91 sdk/lib/_internal/pub/lib/src/http.dart:91: request.url.host == "storage.googleapis.com")) { On 2014/06/05 00:25:41, nweiz wrote: ...
6 years, 6 months ago (2014-06-05 00:42:27 UTC) #3
nweiz
lgtm
6 years, 6 months ago (2014-06-05 00:53:24 UTC) #4
Bob Nystrom
6 years, 6 months ago (2014-06-05 17:07:41 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r37034 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698