Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 317443004: Uses assembler macro for dart SP setup on arm64. (Closed)

Created:
6 years, 6 months ago by zra
Modified:
6 years, 6 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Uses assembler macro for dart SP setup on arm64. Clean up for last CL. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=36950

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -32 lines) Patch
M runtime/vm/assembler_arm64.h View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64_test.cc View 1 41 chunks +56 lines, -27 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
zra
6 years, 6 months ago (2014-06-03 20:21:36 UTC) #1
regis
https://codereview.chromium.org/317443004/diff/1/runtime/vm/assembler_arm64_test.cc File runtime/vm/assembler_arm64_test.cc (right): https://codereview.chromium.org/317443004/diff/1/runtime/vm/assembler_arm64_test.cc#newcode296 runtime/vm/assembler_arm64_test.cc:296: __ ret(); You need to copy SP to CSP ...
6 years, 6 months ago (2014-06-03 20:50:54 UTC) #2
zra
https://codereview.chromium.org/317443004/diff/1/runtime/vm/assembler_arm64_test.cc File runtime/vm/assembler_arm64_test.cc (right): https://codereview.chromium.org/317443004/diff/1/runtime/vm/assembler_arm64_test.cc#newcode296 runtime/vm/assembler_arm64_test.cc:296: __ ret(); On 2014/06/03 20:50:54, regis wrote: > You ...
6 years, 6 months ago (2014-06-03 21:25:50 UTC) #3
regis
LGTM
6 years, 6 months ago (2014-06-03 21:36:36 UTC) #4
zra
6 years, 6 months ago (2014-06-03 21:42:00 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r36950 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698