Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 317423002: Kill java to terminate editor on linux. (Closed)

Created:
6 years, 6 months ago by messick
Modified:
6 years, 6 months ago
Reviewers:
ricow1, Bill Hesse
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Kill java to terminate editor on linux. The DartEditor process can be killed without causing the editor to terminate. I believe that in addition to killing it we also need to stop the jvm. Plus, it needs to be done in order or else the DartEditor process will display an error dialog when the jvm is killed. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=37099

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/task_kill.py View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
messick
6 years, 6 months ago (2014-06-06 17:13:05 UTC) #1
ricow1
lgtm https://codereview.chromium.org/317423002/diff/1/tools/task_kill.py File tools/task_kill.py (right): https://codereview.chromium.org/317423002/diff/1/tools/task_kill.py#newcode200 tools/task_kill.py:200: status += Kill("java") if the order here is ...
6 years, 6 months ago (2014-06-06 19:05:14 UTC) #2
messick
Committed patchset #2 manually as r37099 (presubmit successful).
6 years, 6 months ago (2014-06-06 20:18:21 UTC) #3
messick
6 years, 6 months ago (2014-06-06 20:18:30 UTC) #4
Message was sent while issue was closed.
On 2014/06/06 19:05:14, ricow1 wrote:
> lgtm
> 
> https://codereview.chromium.org/317423002/diff/1/tools/task_kill.py
> File tools/task_kill.py (right):
> 
> https://codereview.chromium.org/317423002/diff/1/tools/task_kill.py#newcode200
> tools/task_kill.py:200: status += Kill("java")
> if the order here is really important, please add a comment stating that here
-
> otherwise this may easily be lost in a refactoring.

Done

Powered by Google App Engine
This is Rietveld 408576698