Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 317273005: VM: Make ZoneAllocated-objects that don't need a vtable smaller. (Closed)

Created:
6 years, 6 months ago by Florian Schneider
Modified:
6 years, 6 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: Make ZoneAllocated-objects that don't need a vtable smaller. Remove virtual destructor from ZoneAllocated. Instead, subclasses that need one have it explicitly declared. This makes ZoneAllocated objects without virtual functions smaller because there won't be a vtable for them. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37228

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M runtime/vm/allocation.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/allocation.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/ast.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/zone_test.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Florian Schneider
6 years, 6 months ago (2014-06-06 10:57:58 UTC) #1
srdjan
How do you now catch that someone does not mistakenly call delete on a ZoneAllocated ...
6 years, 6 months ago (2014-06-06 15:02:56 UTC) #2
Florian Schneider
On 2014/06/06 15:02:56, srdjan wrote: > How do you now catch that someone does not ...
6 years, 6 months ago (2014-06-10 08:44:04 UTC) #3
srdjan
lgtm
6 years, 6 months ago (2014-06-10 14:25:36 UTC) #4
Florian Schneider
6 years, 6 months ago (2014-06-11 10:54:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r37228 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698